core/src/fxcodec/jbig2/JBig2_Context.cpp - Issue 1405723003: Sanity check the values of TRUE and FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/jbig2/JBig2_Context.cpp

Issue 1405723003: Sanity check the values of TRUE and FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/jbig2/JBig2_Context.cpp

diff --git a/core/src/fxcodec/jbig2/JBig2_Context.cpp b/core/src/fxcodec/jbig2/JBig2_Context.cpp

index 06863b0bc49a2d69c26855a4ad4654c992054b59..8473cf1555a119dee699a2fbc230d0212608e733 100644

--- a/core/src/fxcodec/jbig2/JBig2_Context.cpp

+++ b/core/src/fxcodec/jbig2/JBig2_Context.cpp

@@ -381,7 +381,7 @@ int32_t CJBig2_Context::ProcessingParseSegmentData(CJBig2_Segment* pSegment,

m_pStream->readShortInteger(&wTemp) != 0) {

return JBIG2_ERROR_TOO_SHORT;

}

- pPageInfo->m_bIsStriped = ((wTemp >> 15) & 1) ? TRUE : FALSE;

+ pPageInfo->m_bIsStriped = (wTemp >> 15) & 1;

Tom Sepez 2015/10/15 17:08:31 nit: prefer !!(wTemp & 0xSomething)

Lei Zhang 2015/10/19 08:56:18 Done.

pPageInfo->m_wMaxStripeSize = wTemp & 0x7fff;

bool bMaxHeight = (pPageInfo->m_dwHeight == 0xffffffff);

if (bMaxHeight && pPageInfo->m_bIsStriped != TRUE)