Sanity check the values of TRUE and FALSE.

core/include/fxge/fx_dib.h

Index: core/include/fxge/fx_dib.h
diff --git a/core/include/fxge/fx_dib.h b/core/include/fxge/fx_dib.h
index 818aaac5209adbd867aee6ca91b5cc81bd1ccd33..66ff1304b069d887b971252bae6e6b485e0adec3 100644
--- a/core/include/fxge/fx_dib.h
+++ b/core/include/fxge/fx_dib.h
@@ -198,11 +198,11 @@ class CFX_DIBSource {
 
   FX_BOOL IsAlphaMask() const { return m_AlphaFlag == 1; }

[Tom Sepez, 2015/10/15 17:08:31]

This one feels wrong.  If its a mask, all bits should be independent.  Can you
look into this? Or at least write a comment about if the value is 1, then its
one thing, otherwise its a bitmask.

[Lei Zhang, 2015/10/19 08:56:18]

I looked at this briefly and added comments. With our current test repo, we only
ever see values of 0-2, though 4 should be possible with a test case.

 
-  FX_BOOL HasAlpha() const { return m_AlphaFlag & 2 ? TRUE : FALSE; }
+  FX_BOOL HasAlpha() const { return m_AlphaFlag & 2; }

[Tom Sepez, 2015/10/15 17:08:31]

Actually, what you want is { return !!(m_AlphaFlag & 2); } to force 0/1-ness. 
The !! idiom is well-known so we can use it without elaboration.

[Lei Zhang, 2015/10/19 08:56:18]

Done.

 
   FX_BOOL IsOpaqueImage() const { return !(m_AlphaFlag & 3); }
 
-  FX_BOOL IsCmykImage() const { return m_AlphaFlag & 4 ? TRUE : FALSE; }
+  FX_BOOL IsCmykImage() const { return m_AlphaFlag & 4; }
 
   int GetPaletteSize() const {
     return IsAlphaMask() ? 0 : (m_bpp == 1 ? 2 : (m_bpp == 8 ? 256 : 0));