Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 14057019: Fix overflow in history expiry code in 64 bit builds. (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Fix overflow in history expiry code in 64 bit builds. ArchiveSomeOldHistory() takes an int as last parameter, but this code would pass numeric_limits<size_t>::max(). Found by clang building in C++11 mode: ../../chrome/browser/history/expire_history_backend.cc:330:25: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion] std::numeric_limits<size_t>::max()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. BUG=233330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/history/expire_history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
7 years, 8 months ago (2013-04-18 23:01:45 UTC) #1
brettw
lgtm
7 years, 8 months ago (2013-04-18 23:06:18 UTC) #2
Nico
7 years, 8 months ago (2013-04-19 03:06:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r195056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698