runtime/vm/assembler_x64.h - Issue 14057004: Convert diamond shaped control flow into a single conditional instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64.h

Issue 14057004: Convert diamond shaped control flow into a single conditional instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address Florian's comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_x64.h

diff --git a/runtime/vm/assembler_x64.h b/runtime/vm/assembler_x64.h

index 6f049bbdec9a1c5e6961567cbe622d484e5d8dc5..6d5072aa5a6b0453b8f7df1eb852f16ee0aa4924 100644

--- a/runtime/vm/assembler_x64.h

+++ b/runtime/vm/assembler_x64.h

@@ -339,6 +339,8 @@ class Assembler : public ValueObject {

void popq(Register reg);

void popq(const Address& address);

+ void setcc(Condition condition, ByteRegister dst);

void movl(Register dst, Register src);

void movl(Register dst, const Immediate& imm);

void movl(Register dst, const Address& src);

« no previous file with comments | « runtime/vm/assembler_ia32_test.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')