Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 14057004: Convert diamond shaped control flow into a single conditional instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Florian's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 // Generate 2 NOP instructions so that the debugger can patch the return 99 // Generate 2 NOP instructions so that the debugger can patch the return
100 // pattern (1 instruction) with a call to the debug stub (3 instructions). 100 // pattern (1 instruction) with a call to the debug stub (3 instructions).
101 __ nop(); 101 __ nop();
102 __ nop(); 102 __ nop();
103 compiler->AddCurrentDescriptor(PcDescriptors::kReturn, 103 compiler->AddCurrentDescriptor(PcDescriptors::kReturn,
104 Isolate::kNoDeoptId, 104 Isolate::kNoDeoptId,
105 token_pos()); 105 token_pos());
106 } 106 }
107 107
108 108
109 bool IfThenElseInstr::IsSupported() {
110 return false;
111 }
112
113
114 bool IfThenElseInstr::Supports(ComparisonInstr* comparison,
115 Value* v1,
116 Value* v2) {
117 UNREACHABLE();
118 return false;
119 }
120
121
122 LocationSummary* IfThenElseInstr::MakeLocationSummary() const {
123 UNREACHABLE();
124 return NULL;
125 }
126
127
128 void IfThenElseInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
129 UNREACHABLE();
130 }
131
132
109 LocationSummary* ClosureCallInstr::MakeLocationSummary() const { 133 LocationSummary* ClosureCallInstr::MakeLocationSummary() const {
110 UNIMPLEMENTED(); 134 UNIMPLEMENTED();
111 return NULL; 135 return NULL;
112 } 136 }
113 137
114 138
115 LocationSummary* LoadLocalInstr::MakeLocationSummary() const { 139 LocationSummary* LoadLocalInstr::MakeLocationSummary() const {
116 return LocationSummary::Make(0, 140 return LocationSummary::Make(0,
117 Location::RequiresRegister(), 141 Location::RequiresRegister(),
118 LocationSummary::kNoCall); 142 LocationSummary::kNoCall);
(...skipping 798 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 941
918 942
919 void CreateClosureInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 943 void CreateClosureInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
920 UNIMPLEMENTED(); 944 UNIMPLEMENTED();
921 } 945 }
922 946
923 } // namespace dart 947 } // namespace dart
924 948
925 #endif // defined TARGET_ARCH_MIPS 949 #endif // defined TARGET_ARCH_MIPS
926 950
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698