Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 14057004: Convert diamond shaped control flow into a single conditional instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Florian's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // Generate 2 NOP instructions so that the debugger can patch the return 96 // Generate 2 NOP instructions so that the debugger can patch the return
97 // pattern (1 instruction) with a call to the debug stub (3 instructions). 97 // pattern (1 instruction) with a call to the debug stub (3 instructions).
98 __ nop(); 98 __ nop();
99 __ nop(); 99 __ nop();
100 compiler->AddCurrentDescriptor(PcDescriptors::kReturn, 100 compiler->AddCurrentDescriptor(PcDescriptors::kReturn,
101 Isolate::kNoDeoptId, 101 Isolate::kNoDeoptId,
102 token_pos()); 102 token_pos());
103 } 103 }
104 104
105 105
106 bool IfThenElseInstr::IsSupported() {
107 return false;
108 }
109
110
111 bool IfThenElseInstr::Supports(ComparisonInstr* comparison,
112 Value* v1,
113 Value* v2) {
114 UNREACHABLE();
115 return false;
116 }
117
118
119 LocationSummary* IfThenElseInstr::MakeLocationSummary() const {
120 UNREACHABLE();
121 return NULL;
122 }
123
124
125 void IfThenElseInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
126 UNREACHABLE();
127 }
128
129
106 LocationSummary* ClosureCallInstr::MakeLocationSummary() const { 130 LocationSummary* ClosureCallInstr::MakeLocationSummary() const {
107 UNIMPLEMENTED(); 131 UNIMPLEMENTED();
108 return NULL; 132 return NULL;
109 } 133 }
110 134
111 135
112 LocationSummary* LoadLocalInstr::MakeLocationSummary() const { 136 LocationSummary* LoadLocalInstr::MakeLocationSummary() const {
113 return LocationSummary::Make(0, 137 return LocationSummary::Make(0,
114 Location::RequiresRegister(), 138 Location::RequiresRegister(),
115 LocationSummary::kNoCall); 139 LocationSummary::kNoCall);
(...skipping 1639 matching lines...) Expand 10 before | Expand all | Expand 10 after
1755 1779
1756 1780
1757 void CreateClosureInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1781 void CreateClosureInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1758 UNIMPLEMENTED(); 1782 UNIMPLEMENTED();
1759 } 1783 }
1760 1784
1761 } // namespace dart 1785 } // namespace dart
1762 1786
1763 #endif // defined TARGET_ARCH_ARM 1787 #endif // defined TARGET_ARCH_ARM
1764 1788
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698