Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: runtime/vm/assembler_x64.cc

Issue 14057004: Convert diamond shaped control flow into a single conditional instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Florian's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/memory_region.h" 10 #include "vm/memory_region.h"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 149
150 void Assembler::popq(const Address& address) { 150 void Assembler::popq(const Address& address) {
151 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 151 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
152 EmitOperandREX(0, address, REX_NONE); 152 EmitOperandREX(0, address, REX_NONE);
153 EmitUint8(0x8F); 153 EmitUint8(0x8F);
154 EmitOperand(0, address); 154 EmitOperand(0, address);
155 } 155 }
156 156
157 157
158 void Assembler::setcc(Condition condition, ByteRegister dst) {
159 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
160 EmitUint8(0x0F);
161 EmitUint8(0x90 + condition);
162 EmitUint8(0xC0 + dst);
163 }
164
165
158 void Assembler::movl(Register dst, Register src) { 166 void Assembler::movl(Register dst, Register src) {
159 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 167 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
160 Operand operand(src); 168 Operand operand(src);
161 EmitOperandREX(dst, operand, REX_NONE); 169 EmitOperandREX(dst, operand, REX_NONE);
162 EmitUint8(0x8B); 170 EmitUint8(0x8B);
163 EmitOperand(dst & 7, operand); 171 EmitOperand(dst & 7, operand);
164 } 172 }
165 173
166 174
167 void Assembler::movl(Register dst, const Immediate& imm) { 175 void Assembler::movl(Register dst, const Immediate& imm) {
(...skipping 2337 matching lines...) Expand 10 before | Expand all | Expand 10 after
2505 2513
2506 const char* Assembler::FpuRegisterName(FpuRegister reg) { 2514 const char* Assembler::FpuRegisterName(FpuRegister reg) {
2507 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 2515 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
2508 return xmm_reg_names[reg]; 2516 return xmm_reg_names[reg];
2509 } 2517 }
2510 2518
2511 2519
2512 } // namespace dart 2520 } // namespace dart
2513 2521
2514 #endif // defined TARGET_ARCH_X64 2522 #endif // defined TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698