Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 14057003: Remove profiler thread related methods from RuntimeProfiler (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow, loislo
CC:
chromium-reviews
Visibility:
Public.

Description

Remove profiler thread related methods from RuntimeProfiler Now that V8 doesn't use sampling thread for optimizations the methods can be removed. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14214

Patch Set 1 #

Patch Set 2 : Removed unused static fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -169 lines) Patch
M src/isolate.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/platform-cygwin.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/platform-freebsd.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-macos.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/platform-openbsd.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/platform-solaris.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime-profiler.h View 1 4 chunks +0 lines, -60 lines 0 comments Download
M src/runtime-profiler.cc View 1 4 chunks +0 lines, -63 lines 0 comments Download
M src/v8.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 8 months ago (2013-04-10 13:07:09 UTC) #1
yurys
7 years, 8 months ago (2013-04-10 13:16:44 UTC) #2
loislo
lgtm
7 years, 8 months ago (2013-04-10 13:20:20 UTC) #3
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-10 13:53:22 UTC) #4
yurys
7 years, 8 months ago (2013-04-10 14:42:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698