Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405693002: LayoutListItem: shorten refs, use nullptr. (Closed)

Created:
5 years, 2 months ago by wkorman
Modified:
5 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutListItem: shorten refs, use nullptr. BUG=472084 Committed: https://crrev.com/8faa90dc61db5a63c6974f635602b65dfc35192d Cr-Commit-Position: refs/heads/master@{#354063}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutListItem.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 3 chunks +6 lines, -5 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
wkorman
Breakout from http://crrev.com/1403643002
5 years, 2 months ago (2015-10-14 03:56:24 UTC) #2
eae
LGTM https://codereview.chromium.org/1405693002/diff/1/third_party/WebKit/Source/core/layout/LayoutListItem.cpp File third_party/WebKit/Source/core/layout/LayoutListItem.cpp (right): https://codereview.chromium.org/1405693002/diff/1/third_party/WebKit/Source/core/layout/LayoutListItem.cpp#newcode57 third_party/WebKit/Source/core/layout/LayoutListItem.cpp:57: StyleImage* currentImage = style()->listStyleImage(); const?
5 years, 2 months ago (2015-10-14 10:52:18 UTC) #3
wkorman
On 2015/10/14 at 10:52:18, eae wrote: > LGTM > > https://codereview.chromium.org/1405693002/diff/1/third_party/WebKit/Source/core/layout/LayoutListItem.cpp > File third_party/WebKit/Source/core/layout/LayoutListItem.cpp (right): ...
5 years, 2 months ago (2015-10-14 16:48:01 UTC) #4
wkorman
On 2015/10/14 at 16:48:01, wkorman wrote: > On 2015/10/14 at 10:52:18, eae wrote: > > ...
5 years, 2 months ago (2015-10-14 16:49:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405693002/1
5 years, 2 months ago (2015-10-14 16:50:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 18:10:43 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 18:11:52 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8faa90dc61db5a63c6974f635602b65dfc35192d
Cr-Commit-Position: refs/heads/master@{#354063}

Powered by Google App Engine
This is Rietveld 408576698