test/cctest/test-code-stubs-mips64.cc - Issue 1405673003: provides a mechanism for optimizing compilers to select the different Register configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-code-stubs-mips64.cc

Issue 1405673003: provides a mechanism for optimizing compilers to select the different Register configuration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add the TODO comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-code-stubs-mips64.cc

diff --git a/test/cctest/test-code-stubs-mips64.cc b/test/cctest/test-code-stubs-mips64.cc

index fde2d07a9c12864b3096b9e9d7d9dec8daa3cbb6..929c4c326ca955b98acf04f3ab4d3f9e2dca1e31 100644

--- a/test/cctest/test-code-stubs-mips64.cc

+++ b/test/cctest/test-code-stubs-mips64.cc

@@ -80,7 +80,8 @@ ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,

// Save registers make sure they don't get clobbered.

int source_reg_offset = kDoubleSize;

int reg_num = 2;

- const RegisterConfiguration* config = RegisterConfiguration::ArchDefault();

+ const RegisterConfiguration* config =

+ RegisterConfiguration::ArchDefault(RegisterConfiguration::CRANKSHAFT);

for (; reg_num < config->num_allocatable_general_registers(); ++reg_num) {

if (!reg.is(destination_reg)) {

« no previous file with comments | « test/cctest/compiler/test-run-native-calls.cc ('k') | test/cctest/test-code-stubs-x64.cc » ('j') | no next file with comments »