src/x64/deoptimizer-x64.cc - Issue 1405673003: provides a mechanism for optimizing compilers to select the different Register configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/deoptimizer-x64.cc

Issue 1405673003: provides a mechanism for optimizing compilers to select the different Register configuration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add the TODO comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/deoptimizer-x64.cc

diff --git a/src/x64/deoptimizer-x64.cc b/src/x64/deoptimizer-x64.cc

index 1e6e3dd77a97e73ac2da12b2a9a2019a1bab7c06..620f614aa564cb3c8e103c58c8fee09b8a28ed56 100644

--- a/src/x64/deoptimizer-x64.cc

+++ b/src/x64/deoptimizer-x64.cc

@@ -142,7 +142,8 @@ void Deoptimizer::TableEntryGenerator::Generate() {

const int kDoubleRegsSize = kDoubleSize * XMMRegister::kMaxNumRegisters;

__ subp(rsp, Immediate(kDoubleRegsSize));

- const RegisterConfiguration* config = RegisterConfiguration::ArchDefault();

+ const RegisterConfiguration* config =

+ RegisterConfiguration::ArchDefault(RegisterConfiguration::CRANKSHAFT);

for (int i = 0; i < config->num_allocatable_double_registers(); ++i) {

int code = config->GetAllocatableDoubleCode(i);

XMMRegister xmm_reg = XMMRegister::from_code(code);

« no previous file with comments | « src/register-configuration.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »