Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/register-configuration.h

Issue 1405673003: provides a mechanism for optimizing compilers to select the different Register configuration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/register-configuration.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/register-configuration.h
diff --git a/src/register-configuration.h b/src/register-configuration.h
index f12bc7c07c6dfb4beb79477f5a88ce16502b4c71..8c6b21852e1726f645835bffd2aea587cbafe3cc 100644
--- a/src/register-configuration.h
+++ b/src/register-configuration.h
@@ -10,6 +10,9 @@
namespace v8 {
namespace internal {
+// Define the optimized compiler type.
+enum JITCompiler { CRANKSHAFT, TURBOFAN };
danno 2015/10/19 10:48:59 Please put this inside the RegisterConfiguration c
+
// An architecture independent representation of the sets of registers available
// for instruction creation.
class RegisterConfiguration {
@@ -18,7 +21,8 @@ class RegisterConfiguration {
static const int kMaxGeneralRegisters = 32;
static const int kMaxDoubleRegisters = 32;
- static const RegisterConfiguration* ArchDefault();
+ static const RegisterConfiguration* ArchDefault(
+ JITCompiler compiler = CRANKSHAFT);
danno 2015/10/19 10:48:59 Please don't specify a parameter default here, it
RegisterConfiguration(int num_general_registers, int num_double_registers,
int num_allocatable_general_registers,
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/register-configuration.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698