Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1405653002: Update version number in pkg/js pubspec in preparation for publishing the package. (Closed)

Created:
5 years, 2 months ago by Jacob
Modified:
5 years, 2 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update version number in pkg/js pubspec in preparation for publishing the package. BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/sdk/commit/6dd851e2a45bddbbe685c5a424c9f33542fae034

Patch Set 1 #

Total comments: 1

Patch Set 2 : ptal #

Patch Set 3 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M pkg/js/pubspec.yaml View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jacob
I'll land and publish this package tomorrow
5 years, 2 months ago (2015-10-13 21:50:40 UTC) #2
kevmoo
Pending a final "looks good" until I can verify on my machine w/ released dev ...
5 years, 2 months ago (2015-10-13 21:52:30 UTC) #3
Jacob
Updated the homepage location of the package to reflect that the package has been moved ...
5 years, 2 months ago (2015-10-13 22:26:55 UTC) #4
Jacob
Updated the homepage location of the package to reflect that the package has been moved ...
5 years, 2 months ago (2015-10-13 22:26:57 UTC) #5
kevmoo
LGTM – waiting on homebrew release to try it out on my machine
5 years, 2 months ago (2015-10-14 18:52:31 UTC) #6
Jacob
5 years, 2 months ago (2015-10-15 16:40:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6dd851e2a45bddbbe685c5a424c9f33542fae034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698