Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1405643002: Issue 24566. Main AnalysisContext.getLibrariesContaining() should work also for SDK sources. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 24566. Main AnalysisContext.getLibrariesContaining() should work also for SDK sources. This also fixes IDEA's Iterable hierarchy problem. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24566 Committed: https://github.com/dart-lang/sdk/commit/a41819650e54165cae4be4dd4f6e1f00c8b78d47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -15 lines) Patch
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 3 chunks +26 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +16 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-13 21:01:59 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-13 21:23:27 UTC) #2
scheglov
5 years, 2 months ago (2015-10-13 21:25:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a41819650e54165cae4be4dd4f6e1f00c8b78d47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698