Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: lib/test.dart

Issue 1405633004: feature: tag tests; choose tags on command line Base URL: git@github.com:yjbanov/test.git@tags
Patch Set: address review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/test.dart
diff --git a/lib/test.dart b/lib/test.dart
index 4d19aa0151475da939b017571da2fa00fb1af768..511b349afc85e69d72f4c2cbefda49640b2db099 100644
--- a/lib/test.dart
+++ b/lib/test.dart
@@ -112,11 +112,18 @@ Declarer get _declarer {
///
/// If multiple platforms match, the annotations apply in order as through
/// they were in nested groups.
-void test(String description, body(), {String testOn, Timeout timeout,
- skip, Map<String, dynamic> onPlatform, String tag,
- List<String> tags}) => _declarer.test(description, body,
- testOn: testOn, timeout: timeout, skip: skip,
- onPlatform: onPlatform, tags: _deconvenienceTags(tag, tags));
+void test(String description, body(),
+ {String testOn,
+ Timeout timeout,
+ skip,
+ Map<String, dynamic> onPlatform,
+ tags}) =>
+ _declarer.test(description, body,
+ testOn: testOn,
+ timeout: timeout,
+ skip: skip,
+ onPlatform: onPlatform,
+ tags: tags);
/// Creates a group of tests.
///
@@ -157,11 +164,14 @@ void test(String description, body(), {String testOn, Timeout timeout,
///
/// If multiple platforms match, the annotations apply in order as through
/// they were in nested groups.
-void group(String description, void body(), {String testOn, Timeout timeout,
- skip, Map<String, dynamic> onPlatform, String tag,
- List<String> tags}) => _declarer.group(description, body,
- testOn: testOn, timeout: timeout, skip: skip,
- tags: _deconvenienceTags(tag, tags));
+void group(String description, void body(),
+ {String testOn,
+ Timeout timeout,
+ skip,
+ Map<String, dynamic> onPlatform,
+ tags}) =>
+ _declarer.group(description, body,
+ testOn: testOn, timeout: timeout, skip: skip, tags: tags);
/// Registers a function to be run before tests.
///
@@ -223,13 +233,3 @@ void registerException(error, [StackTrace stackTrace]) {
// going through the zone API allows other zones to consistently see errors.
Zone.current.handleUncaughtError(error, stackTrace);
}
-
-List<String> _deconvenienceTags(String tag, List<String> tags) {
- var result = const[];
- if (tag != null || (tags != null && tags.isNotEmpty)) {
- result = [];
- if (tag != null) result.add(tag);
- if (tags != null && tags.isNotEmpty) result.addAll(tags);
- }
- return result;
-}

Powered by Google App Engine
This is Rietveld 408576698