Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4030)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_stats_recorder.h

Issue 1405633003: Converts TabStripModelStatsRecorder to use BrowserTabStripTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/tabs/tab_strip_model_stats_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/tab_strip_model_stats_recorder.h
diff --git a/chrome/browser/ui/tabs/tab_strip_model_stats_recorder.h b/chrome/browser/ui/tabs/tab_strip_model_stats_recorder.h
index 57a7a9a39137dcbae7563a6d8ebe9eb76371a2ee..fbb980dc9f081d01fa98f9787e8cc862eb9562cf 100644
--- a/chrome/browser/ui/tabs/tab_strip_model_stats_recorder.h
+++ b/chrome/browser/ui/tabs/tab_strip_model_stats_recorder.h
@@ -8,8 +8,7 @@
#include <vector>
#include "base/macros.h"
-
-#include "chrome/browser/ui/browser_list_observer.h"
+#include "chrome/browser/ui/browser_tab_strip_tracker.h"
#include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
namespace content {
@@ -19,8 +18,7 @@ class WebContents;
// TabStripModelStatsRecorder records user tab interaction stats.
// In particular, we record tab's lifetime and state transition probability to
// study user interaction with background tabs. (crbug.com/517335)
-class TabStripModelStatsRecorder : public chrome::BrowserListObserver,
- public TabStripModelObserver {
+class TabStripModelStatsRecorder : public TabStripModelObserver {
public:
// TabState represents a lifecycle of a tab in TabStripModel.
// This should match {Current,Next}TabState defined in
@@ -50,10 +48,6 @@ class TabStripModelStatsRecorder : public chrome::BrowserListObserver,
~TabStripModelStatsRecorder() override;
private:
- // chrome::BrowserListObserver implementation.
- void OnBrowserAdded(Browser* browser) override;
- void OnBrowserRemoved(Browser* browser) override;
-
// TabStripModelObserver implementation.
void TabClosingAt(TabStripModel* tab_strip_model,
content::WebContents* contents,
@@ -71,6 +65,8 @@ class TabStripModelStatsRecorder : public chrome::BrowserListObserver,
std::vector<content::WebContents*> active_tab_history_;
+ BrowserTabStripTracker browser_tab_strip_tracker_;
+
DISALLOW_COPY_AND_ASSIGN(TabStripModelStatsRecorder);
};
« no previous file with comments | « no previous file | chrome/browser/ui/tabs/tab_strip_model_stats_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698