cloud_print/service/service.gyp - Issue 1405633002: Cleanup chrome/version.h handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/service.gyp

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Building Chrome is hard Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/service.gyp

diff --git a/cloud_print/service/service.gyp b/cloud_print/service/service.gyp

index a6171a897e3d6c5a91ea0079124b743513470e78..1b8396f25014b9dc4ea7b0f5f1f65cfa3a8e2767 100644

--- a/cloud_print/service/service.gyp

+++ b/cloud_print/service/service.gyp

@@ -60,9 +60,9 @@

'conditions': [

['OS=="win"', {

'dependencies': [

- '<(DEPTH)/chrome/chrome.gyp:chrome_version_header',

'<(DEPTH)/chrome/chrome.gyp:launcher_support',

'<(DEPTH)/chrome/common_constants.gyp:common_constants',

+ '<(DEPTH)/chrome/common_constants.gyp:version_header',

}],

['OS=="win" and clang==1', {