chrome/installer/setup/setup_main.cc - Issue 1405633002: Cleanup chrome/version.h handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Building Chrome is hard Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/setup_main.cc

diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc

index ae5065920ecb9e9c4939eae7d98c3329fb525455..94cab45ba3f5895a4898e40d014ffe7c7805c734 100644

--- a/chrome/installer/setup/setup_main.cc

+++ b/chrome/installer/setup/setup_main.cc

@@ -40,6 +40,7 @@

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

+#include "chrome/common/chrome_version.h"

#include "chrome/installer/setup/archive_patch_helper.h"

#include "chrome/installer/setup/install.h"

#include "chrome/installer/setup/install_worker.h"

@@ -68,7 +69,6 @@

#include "chrome/installer/util/self_cleaning_temp_dir.h"

#include "chrome/installer/util/shell_util.h"

#include "chrome/installer/util/user_experiment.h"

-#include "version.h" // NOLINT

#if defined(GOOGLE_CHROME_BUILD)

#include "chrome/installer/util/updating_app_registration_data.h"

« no previous file with comments | « chrome/installer/setup/BUILD.gn ('k') | chrome/test/chromedriver/BUILD.gn » ('j') | no next file with comments »