Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(80)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: chrome/common/chrome_version.h.in
Issue
1405633002
:
Cleanup chrome/version.h handling (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Building Chrome is hard
Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/BUILD.gn
chrome/browser/BUILD.gn
chrome/browser/chrome_elf_init_unittest_win.cc
chrome/browser/chrome_elf_init_win.cc
chrome/browser/google/google_update_win_unittest.cc
chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc
chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc
chrome/chrome.gyp
chrome/chrome_browser.gypi
chrome/chrome_installer.gypi
chrome/chrome_tests.gypi
chrome/common/BUILD.gn
chrome/common/chrome_constants.cc
chrome/common/chrome_version.cc.version
chrome/common/chrome_version.h.in
chrome/common_constants.gyp
chrome/installer/setup/BUILD.gn
chrome/installer/setup/setup_main.cc
chrome/test/chromedriver/BUILD.gn
chrome/version.h.in
chrome_elf/BUILD.gn
chrome_elf/DEPS
chrome_elf/blacklist/test/blacklist_test.cc
chrome_elf/breakpad.cc
chrome_elf/chrome_elf.gyp
cloud_print/cloud_print_resources.gyp
cloud_print/service/service.gyp
cloud_print/virtual_driver/win/port_monitor/BUILD.gn
cloud_print/virtual_driver/win/virtual_driver.gypi
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« chrome/common/chrome_version.cc.version
('k') |
chrome/common_constants.gyp »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: chrome/common/chrome_version.h.in
diff --git a/chrome/version.h.in b/chrome/common/chrome_version.h.in
similarity index 100%
rename from chrome/version.h.in
rename to chrome/common/chrome_version.h.in
« no previous file with comments
|
« chrome/common/chrome_version.cc.version
('k') |
chrome/common_constants.gyp »
('j') |
no next file with comments »
Issue 1405633002: Cleanup chrome/version.h handling (Closed)
Created 5 years, 2 months ago by mdempsky
Modified 5 years, 2 months ago
Reviewers: brettw
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0
This is Rietveld
408576698