chrome/chrome.gyp - Issue 1405633002: Cleanup chrome/version.h handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.gyp

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Building Chrome is hard Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome.gyp

diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp

index 5fae3f0a61a3d54dc8743fadf985d9ea84274e50..c9986e18bf93c56f3f5024b58a5ae48f71c30f16 100644

--- a/chrome/chrome.gyp

+++ b/chrome/chrome.gyp

@@ -415,41 +415,6 @@

{

- # GN version: //chrome:version_header

- 'target_name': 'chrome_version_header',

- 'type': 'none',

- 'hard_dependency': 1,

- 'actions': [

- {

- 'action_name': 'version_header',

- 'variables': {

- 'lastchange_path':

- '<(DEPTH)/build/util/LASTCHANGE',

- 'branding_path': 'app/theme/<(branding_path_component)/BRANDING',

- },

- 'inputs': [

- '<(version_path)',

- '<(branding_path)',

- '<(lastchange_path)',

- 'version.h.in',

- ],

- 'outputs': [

- '<(SHARED_INTERMEDIATE_DIR)/version.h',

- ],

- 'action': [

- 'python',

- '<(version_py_path)',

- '-f', '<(version_path)',

- '-f', '<(branding_path)',

- '-f', '<(lastchange_path)',

- 'version.h.in',

- '<@(_outputs)',

- ],

- 'message': 'Generating version header file: <@(_outputs)',

- },

- ],

- },

- {

'target_name': 'crash_service',

'type': 'executable',

'dependencies': [