chrome/browser/chrome_elf_init_win.cc - Issue 1405633002: Cleanup chrome/version.h handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_elf_init_win.cc

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Building Chrome is hard Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_elf_init_win.cc

diff --git a/chrome/browser/chrome_elf_init_win.cc b/chrome/browser/chrome_elf_init_win.cc

index 3d568a69a46ae32568bec069f83140348b0c89e7..28af7f8228ac565760377242847556ba50506668 100644

--- a/chrome/browser/chrome_elf_init_win.cc

+++ b/chrome/browser/chrome_elf_init_win.cc

@@ -9,12 +9,12 @@

#include "base/strings/utf_string_conversions.h"

#include "base/win/registry.h"

#include "chrome/browser/chrome_elf_init_win.h"

+#include "chrome/common/chrome_version.h"

#include "chrome_elf/blacklist/blacklist.h"

#include "chrome_elf/chrome_elf_constants.h"

#include "chrome_elf/dll_hash/dll_hash.h"

#include "components/variations/variations_associated_data.h"

#include "content/public/browser/browser_thread.h"

-#include "version.h" // NOLINT

const char kBrowserBlacklistTrialName[] = "BrowserBlacklist";

const char kBrowserBlacklistTrialDisabledGroupName[] = "NoBlacklist";