Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/common/chrome_constants.cc

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Building Chrome is hard Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_constants.h" 5 #include "chrome/common/chrome_constants.h"
6 #include "chrome/common/chrome_version.h"
6 7
7 #define FPL FILE_PATH_LITERAL 8 #define FPL FILE_PATH_LITERAL
8 9
9 #if defined(OS_MACOSX) 10 #if defined(OS_MACOSX)
10 #define CHROMIUM_PRODUCT_STRING "Chromium" 11 #define CHROMIUM_PRODUCT_STRING "Chromium"
11 #if defined(GOOGLE_CHROME_BUILD) 12 #if defined(GOOGLE_CHROME_BUILD)
12 #define PRODUCT_STRING "Google Chrome" 13 #define PRODUCT_STRING "Google Chrome"
13 #elif defined(CHROMIUM_BUILD) 14 #elif defined(CHROMIUM_BUILD)
14 #define PRODUCT_STRING "Chromium" 15 #define PRODUCT_STRING "Chromium"
15 #else 16 #else
16 #error Unknown branding 17 #error Unknown branding
17 #endif 18 #endif
18 #endif // defined(OS_MACOSX) 19 #endif // defined(OS_MACOSX)
19 20
20 namespace chrome { 21 namespace chrome {
21 22
23 const char kChromeVersion[] = CHROME_VERSION_STRING;
24
22 #if defined(OS_WIN) 25 #if defined(OS_WIN)
23 const char kChromeVersionEnvVar[] = "CHROME_VERSION"; 26 const char kChromeVersionEnvVar[] = "CHROME_VERSION";
24 #endif 27 #endif
25 28
26 // The following should not be used for UI strings; they are meant 29 // The following should not be used for UI strings; they are meant
27 // for system strings only. UI changes should be made in the GRD. 30 // for system strings only. UI changes should be made in the GRD.
28 // 31 //
29 // There are four constants used to locate the executable name and path: 32 // There are four constants used to locate the executable name and path:
30 // 33 //
31 // kBrowserProcessExecutableName 34 // kBrowserProcessExecutableName
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 // user can select for different file types. 230 // user can select for different file types.
228 // {2676A9A2-D919-4FEE-9187-152100393AB2} 231 // {2676A9A2-D919-4FEE-9187-152100393AB2}
229 const char kApplicationClientIDStringForAVScanning[] = 232 const char kApplicationClientIDStringForAVScanning[] =
230 "2676A9A2-D919-4FEE-9187-152100393AB2"; 233 "2676A9A2-D919-4FEE-9187-152100393AB2";
231 234
232 const size_t kMaxMetaTagAttributeLength = 2000; 235 const size_t kMaxMetaTagAttributeLength = 2000;
233 236
234 } // namespace chrome 237 } // namespace chrome
235 238
236 #undef FPL 239 #undef FPL
OLDNEW
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/chrome_version.cc.version » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698