chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc - Issue 1405633002: Cleanup chrome/version.h handling

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Building Chrome is hard Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/google/google_update_win_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_analy zer.h"	5 #include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_analy zer.h"

6	6

7 #include "base/files/file_path.h"	7 #include "base/files/file_path.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/path_service.h"	9 #include "base/path_service.h"

10 #include "version.h" // NOLINT	10 #include "chrome/common/chrome_version.h"

11	11

12 namespace safe_browsing {	12 namespace safe_browsing {

13	13

14 std::vector<base::FilePath> GetCriticalBinariesPath() {	14 std::vector<base::FilePath> GetCriticalBinariesPath() {

15 static const base::FilePath::CharType* const kUnversionedFiles[] = {	15 static const base::FilePath::CharType* const kUnversionedFiles[] = {

16 FILE_PATH_LITERAL("chrome.exe"),	16 FILE_PATH_LITERAL("chrome.exe"),

17 };	17 };

18 static const base::FilePath::CharType* const kVersionedFiles[] = {	18 static const base::FilePath::CharType* const kVersionedFiles[] = {

19 FILE_PATH_LITERAL("chrome.dll"),	19 FILE_PATH_LITERAL("chrome.dll"),

20 FILE_PATH_LITERAL("chrome_child.dll"),	20 FILE_PATH_LITERAL("chrome_child.dll"),

(...skipping 16 matching lines...) Expand all Loading...
37 base::FilePath version_dir(	37 base::FilePath version_dir(

38 chrome_exe_dir.AppendASCII(CHROME_VERSION_STRING));	38 chrome_exe_dir.AppendASCII(CHROME_VERSION_STRING));

39 for (size_t i = 0; i < arraysize(kVersionedFiles); ++i) {	39 for (size_t i = 0; i < arraysize(kVersionedFiles); ++i) {

40 critical_binaries.push_back(version_dir.Append(kVersionedFiles[i]));	40 critical_binaries.push_back(version_dir.Append(kVersionedFiles[i]));

41 }	41 }

42	42

43 return critical_binaries;	43 return critical_binaries;

44 }	44 }

45	45

46 } // namespace safe_browsing	46 } // namespace safe_browsing

OLD	NEW