Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 140563002: Use the VTTCue constructor instead of TextTrackCue in test (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, feature-media-reviews_chromium.org, gasubic, vcarbune.chromium, nessy
Visibility:
Public.

Description

Use the VTTCue constructor instead of TextTrackCue in test The TextTrackCue constructor is being deprecated. BUG=334942 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/media/track/text-track-cue-exceptions.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-16 06:03:53 UTC) #1
philipj_slow
https://codereview.chromium.org/140573002/ also splits this test into two for clarity.
6 years, 11 months ago (2014-01-16 06:04:50 UTC) #2
tkent
lgtm
6 years, 11 months ago (2014-01-16 06:06:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/140563002/1
6 years, 11 months ago (2014-01-16 06:06:29 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 06:14:22 UTC) #5
Message was sent while issue was closed.
Change committed as 165199

Powered by Google App Engine
This is Rietveld 408576698