Added code to enable the first caption track if the user has requested captions and one such track …

Added code to enable the first caption track if the user has requested captions and one such track is available, but not yet displayed.

Update previous timing out test (video-controls-captions) to test
the new logic and removed it from TestExpectations.

Additionally, I separated language behaviour test from the
video-controls-captions into a new test, video-controls-captions-load-by-lang.

BUG=224700
R=scherkus,abarth,eseidel,eae
CC=feature-media-reviews@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148780

[scherkus (not reviewing), 2013-04-17 20:35:36]

this looks LGTM but you'll still need an OWNERS review (abarth/eseidel/eae?)

[abarth-chromium, 2013-04-18 05:36:39]

rs=me (LGTM)

https://codereview.chromium.org/14056005/diff/1/Source/WebCore/html/HTMLMedia...
File Source/WebCore/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/14056005/diff/1/Source/WebCore/html/HTMLMedia...
Source/WebCore/html/HTMLMediaElement.cpp:3976: if (closedCaptionsVisible &&
!m_haveVisibleTextTrack)
Multiline if statements require { } even if they contain only one statement.

https://codereview.chromium.org/14056005/diff/1/Source/WebCore/html/HTMLMedia...
Source/WebCore/html/HTMLMediaElement.cpp:3978: RefPtr<TextTrack> track =
m_textTracks->item(i);
Why RefPtr rather than just TextTrack* ?

[vcarbune.chromium, 2013-04-20 00:30:12]

Thanks for the review, can you please take another look?

My initial fixed was more like a workaround, so I went ahead
through the problem and added an extra test and a proper fix
to this.

Thanks

https://codereview.chromium.org/14056005/diff/1/Source/WebCore/html/HTMLMedia...
File Source/WebCore/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/14056005/diff/1/Source/WebCore/html/HTMLMedia...
Source/WebCore/html/HTMLMediaElement.cpp:3973: // If the user has enabled
captions and no track that is available for
I have removed this part, as it was merely a work-around the real issue.

[eseidel, 2013-04-20 19:01:03]

lgtm

[commit-bot: I haz the power, 2013-04-20 19:01:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vcarbune@chromium.org/14056005/6001

[commit-bot: I haz the power, 2013-04-20 19:01:16]

Failed to apply patch for Source/core/platform/Logging.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/platform/Logging.cpp
  Hunk #1 FAILED at 57.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/platform/Logging.cpp.rej

Patch:       Source/core/platform/Logging.cpp
Index: Source/core/platform/Logging.cpp
diff --git a/Source/core/platform/Logging.cpp b/Source/core/platform/Logging.cpp
index
0a42cb960cce69be85a724e6fd77223e518c9830..d7275d4c4b053f516cfd9d624652ca562c80ccf6
100644
--- a/Source/core/platform/Logging.cpp
+++ b/Source/core/platform/Logging.cpp
@@ -57,7 +57,7 @@ WTFLogChannel LogFTP =               { 0x00200000,
"WebCoreLogLevel", WTFLogChan
 WTFLogChannel LogThreading =         { 0x00400000, "WebCoreLogLevel",
WTFLogChannelOff };
 WTFLogChannel LogStorageAPI =        { 0x00800000, "WebCoreLogLevel",
WTFLogChannelOff };
 
-WTFLogChannel LogMedia =             { 0x01000000, "WebCoreLogLevel",
WTFLogChannelOn  };
+WTFLogChannel LogMedia =             { 0x01000000, "WebCoreLogLevel",
WTFLogChannelOff };
 WTFLogChannel LogPlugins =           { 0x02000000, "WebCoreLogLevel",
WTFLogChannelOff };
 WTFLogChannel LogArchives =          { 0x04000000, "WebCoreLogLevel",
WTFLogChannelOff };
 WTFLogChannel LogProgress =          { 0x08000000, "WebCoreLogLevel",
WTFLogChannelOff };

[commit-bot: I haz the power, 2013-04-20 22:18:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vcarbune@chromium.org/14056005/9003

[commit-bot: I haz the power, 2013-04-20 22:41:14]

Change committed as 148780