Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1405573002: Telemetry: Print the sorted benchmark list when running run_benchmark. (Closed)

Created:
5 years, 2 months ago by zino
Modified:
5 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Print the sorted benchmark list when running run_benchmark. Telemetry users will currently have to see the unsorted benchmark list when running run_benchmark. It can sometimes be inconvenient. Hence, this CL makes the benchmark list sorted and then prints them. BUG=none Committed: https://crrev.com/f52ceea6bb0c82ea07fde667aaf508a28134ba61 Cr-Commit-Position: refs/heads/master@{#353949}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/telemetry/telemetry/benchmark_runner.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
zino
Please take a look. Thank you!
5 years, 2 months ago (2015-10-13 15:09:57 UTC) #2
nednguyen
lgtm Kari: wdyt?
5 years, 2 months ago (2015-10-13 15:26:25 UTC) #3
aiolos (Not reviewing)
lgtm
5 years, 2 months ago (2015-10-13 17:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405573002/1
5 years, 2 months ago (2015-10-13 22:53:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/120180) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 2 months ago (2015-10-13 23:42:03 UTC) #8
zino
On 2015/10/13 23:42:03, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-14 01:31:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405573002/20001
5 years, 2 months ago (2015-10-14 01:32:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 02:37:13 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:37:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f52ceea6bb0c82ea07fde667aaf508a28134ba61
Cr-Commit-Position: refs/heads/master@{#353949}

Powered by Google App Engine
This is Rietveld 408576698