Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: pkg/compiler/lib/src/resolution/registry.dart

Issue 1405563002: Move otherDependencies to globalDependencies. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/resolution/tree_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/registry.dart
diff --git a/pkg/compiler/lib/src/resolution/registry.dart b/pkg/compiler/lib/src/resolution/registry.dart
index 9f978f6f5388a6e9308b131d234b5db6d243987a..b93c6e9eab7b8fa756c7b9a6c2c0a83fc6d59d7b 100644
--- a/pkg/compiler/lib/src/resolution/registry.dart
+++ b/pkg/compiler/lib/src/resolution/registry.dart
@@ -41,7 +41,7 @@ import 'tree_elements.dart' show
TreeElementMapping;
// TODO(johnniwinther): Remove this.
-class EagerRegistry implements Registry {
+class EagerRegistry extends Registry {
final Compiler compiler;
final TreeElementMapping mapping;
@@ -53,19 +53,6 @@ class EagerRegistry implements Registry {
bool get isForResolution => true;
@override
- Iterable<Element> get otherDependencies => mapping.otherDependencies;
-
- @override
- void registerAssert(bool hasMessage) {
- // TODO(johnniwinther): Do something here?
- }
-
- @override
- void registerDependency(Element element) {
- mapping.registerDependency(element);
- }
-
- @override
void registerDynamicGetter(UniverseSelector selector) {
world.registerDynamicGetter(selector);
}
@@ -352,7 +339,7 @@ class _ResolutionWorldImpact implements ResolutionImpact {
/// related information in a [TreeElements] mapping and registers calls with
/// [Backend], [World] and [Enqueuer].
// TODO(johnniwinther): Split this into an interface and implementation class.
-class ResolutionRegistry implements Registry {
+class ResolutionRegistry extends Registry {
final Compiler compiler;
final TreeElementMapping mapping;
final _ResolutionWorldImpact worldImpact;
@@ -715,18 +702,11 @@ class ResolutionRegistry implements Registry {
worldImpact.registerFeature(Feature.THROW_EXPRESSION);
}
- void registerDependency(Element element) {
- mapping.registerDependency(element);
- }
-
- Setlet<Element> get otherDependencies => mapping.otherDependencies;
-
void registerStaticInvocation(Element element) {
// TODO(johnniwinther): Increase precision of [registerStaticUse] and
// [registerDependency].
if (element == null) return;
registerStaticUse(element);
- registerDependency(element);
}
void registerInstantiation(InterfaceType type) {
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/resolution/tree_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698