Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1405563002: Move otherDependencies to globalDependencies. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, Harry Terkelsen
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -73 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +21 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 4 chunks +2 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 7 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 2 months ago (2015-10-13 14:33:57 UTC) #2
sigurdm
LGTM
5 years, 2 months ago (2015-10-14 09:06:27 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-14 09:19:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c77f1527d589d2f52727d13406f10d5b6bc20cfb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698