Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1405553003: Land temporary workaround for clang-cl not yet understanding __emul (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Land temporary workaround for clang-cl not yet understanding __emul BUG=543182 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ae2d47b22d213cb36a66326c3167cfbbae90b9d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/libopenjpeg20/opj_intmath.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
5 years, 2 months ago (2015-10-14 16:34:09 UTC) #2
Tom Sepez
Looks Good, but it also looks like the compiler has already been rev'd.
5 years, 2 months ago (2015-10-14 16:36:24 UTC) #3
Tom Sepez
On 2015/10/14 16:36:24, Tom Sepez wrote: > Looks Good, but it also looks like the ...
5 years, 2 months ago (2015-10-14 16:36:55 UTC) #4
Nico
No, a fix has landed in the compiler's upstream, but the clang binaries we have ...
5 years, 2 months ago (2015-10-14 16:37:37 UTC) #5
Nico
5 years, 2 months ago (2015-10-14 16:37:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae2d47b22d213cb36a66326c3167cfbbae90b9d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698