Issue 140553007: Change --mirror to --bare in gclient_scm.py for cache directories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140553007: Change --mirror to --bare in gclient_scm.py for cache directories (Closed)

Created:
6 years, 10 months ago by Ryan Tseng

Modified:
6 years, 10 months ago

Reviewers:
agable, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Change --mirror to --bare in gclient_scm.py for cache directories BUG=339168 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=250547

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gclient_scm.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

iannucci

Add tracking bug? This LGTM. +agable as FYI, any bots with git_cache's will need to ...

6 years, 10 months ago (2014-02-06 23:19:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/140553007/1

6 years, 10 months ago (2014-02-11 23:23:33 UTC) #4

agable

6 years, 10 months ago (2014-02-11 23:26:31 UTC) #6

Message was sent while issue was closed.

On 2014/02/06 23:19:53, iannucci wrote:
> Add tracking bug?
> 
> This LGTM. +agable as FYI, any bots with git_cache's will need to have their
> caches (and checkouts) probably nuked. 
> 
> This will bork the checkouts (bug to fix filed here:
> https://code.google.com/p/chromium/issues/detail?id=341651)

I honestly don't think anyone is actually using git caches yet. Because
everywhere that passes --cache-dir also passes --spec. :(

Expand Messages | Collapse Messages