Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1405513004: Devtools: Fix soft context menu (Closed)

Created:
5 years, 2 months ago by samli
Modified:
5 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org, yurys+blink_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Fix soft context menu Fixes a regression with the sub menu arrow. Also fixes an issue where the sub-menu is not fully discarded, resulting in empty shadows floating around the UI. BUG=542793 Committed: https://crrev.com/c92fc21706854166bf441aa3e9b089326727f3b7 Cr-Commit-Position: refs/heads/master@{#354203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/softContextMenu.css View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
samli
Before: http://i.imgur.com/UMNWzVY.png Ater: http://i.imgur.com/nByDeiV.png
5 years, 2 months ago (2015-10-13 18:36:47 UTC) #2
samli
+dgozman instead
5 years, 2 months ago (2015-10-13 22:31:40 UTC) #4
samli
ping
5 years, 2 months ago (2015-10-14 23:00:36 UTC) #5
dgozman
lgtm
5 years, 2 months ago (2015-10-14 23:36:13 UTC) #6
dgozman
On 2015/10/14 23:36:13, dgozman wrote: > lgtm Please bring more details in patch description.
5 years, 2 months ago (2015-10-14 23:36:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405513004/1
5 years, 2 months ago (2015-10-14 23:47:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 02:13:36 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 02:15:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c92fc21706854166bf441aa3e9b089326727f3b7
Cr-Commit-Position: refs/heads/master@{#354203}

Powered by Google App Engine
This is Rietveld 408576698