Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1405503003: dart2js cps: Some fixes for yield. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +15 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 2 months ago (2015-10-13 11:29:45 UTC) #2
karlklose
LGTM, thanks!
5 years, 2 months ago (2015-10-13 12:25:55 UTC) #3
asgerf
5 years, 2 months ago (2015-10-13 12:34:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a534459ba6a3beaa86ba4931dc9213973a3f5e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698