Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405463006: Componentize CookieOSCryptoDelegate (Closed)

Created:
5 years, 2 months ago by Abhishek
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize CookieOSCryptoDelegate . Create new cookie_config component. . Adding new .gypi and .gn file. TBR=jochen BUG=516705 Committed: https://crrev.com/bbf8e4a6af6acc7225a26d95d5f353b3f5aa3029 Cr-Commit-Position: refs/heads/master@{#354356}

Patch Set 1 #

Total comments: 16

Patch Set 2 : updated #

Patch Set 3 : adding OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -144 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/net/cookie_store_util.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/net/cookie_store_util.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/browser/profiles/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + components/cookie_config.gypi View 1 1 chunk +7 lines, -5 lines 0 comments Download
A + components/cookie_config/BUILD.gn View 1 1 chunk +5 lines, -5 lines 0 comments Download
A components/cookie_config/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download
A components/cookie_config/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + components/cookie_config/cookie_store_util.h View 1 1 chunk +6 lines, -12 lines 0 comments Download
A + components/cookie_config/cookie_store_util.cc View 1 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 23 (6 generated)
Abhishek
PTAL!
5 years, 2 months ago (2015-10-14 15:08:32 UTC) #1
blundell
On 2015/10/14 15:08:32, Abhishek wrote: > PTAL! (You forgot to add any reviewers ;)
5 years, 2 months ago (2015-10-14 15:10:01 UTC) #2
Abhishek
PTAL ;)
5 years, 2 months ago (2015-10-14 15:59:41 UTC) #4
droger
https://codereview.chromium.org/1405463006/diff/1/components/cookie_config.gypi File components/cookie_config.gypi (right): https://codereview.chromium.org/1405463006/diff/1/components/cookie_config.gypi#newcode12 components/cookie_config.gypi:12: '../base/base.gyp:base', add '../net/net.gyp:net', https://codereview.chromium.org/1405463006/diff/1/components/cookie_config.gypi#newcode13 components/cookie_config.gypi:13: 'os_crypt', indentation https://codereview.chromium.org/1405463006/diff/1/components/cookie_config/BUILD.gn File ...
5 years, 2 months ago (2015-10-14 16:04:39 UTC) #5
Abhishek
Updated as suggested. PTAL# 2! https://codereview.chromium.org/1405463006/diff/1/components/cookie_config.gypi File components/cookie_config.gypi (right): https://codereview.chromium.org/1405463006/diff/1/components/cookie_config.gypi#newcode12 components/cookie_config.gypi:12: '../base/base.gyp:base', On 2015/10/14 16:04:38, ...
5 years, 2 months ago (2015-10-15 08:46:04 UTC) #6
droger
LGTM please add a OWNERS file including at least rdsmith. +rdsmith as OWNER of chrome/browser/net/cookie_store_util ...
5 years, 2 months ago (2015-10-15 09:01:33 UTC) #8
Abhishek
Added OWNERS file with suggested owners by david. PTAL!
5 years, 2 months ago (2015-10-15 09:25:26 UTC) #9
blundell
lgtm
5 years, 2 months ago (2015-10-15 09:27:37 UTC) #10
Randy Smith (Not in Mondays)
lgtm
5 years, 2 months ago (2015-10-15 17:47:41 UTC) #11
Abhishek
+erg: chrome/browser/profiles/ PTAL!
5 years, 2 months ago (2015-10-15 18:17:09 UTC) #13
Elliot Glaysher
trivial namespace change in profiles lgtm
5 years, 2 months ago (2015-10-15 18:24:57 UTC) #14
Abhishek
+jochen: chrome/browser/ PTAL!
5 years, 2 months ago (2015-10-15 18:31:16 UTC) #16
blundell
Those changes are fine to TBR. Make sure you specify exactly what you're TBR'ing for.
5 years, 2 months ago (2015-10-15 18:36:19 UTC) #17
Abhishek
TBR'ing jochen for c/b/BUILD.gn
5 years, 2 months ago (2015-10-15 20:03:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405463006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405463006/40001
5 years, 2 months ago (2015-10-15 20:04:50 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-15 21:06:04 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 21:06:38 UTC) #23
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bbf8e4a6af6acc7225a26d95d5f353b3f5aa3029
Cr-Commit-Position: refs/heads/master@{#354356}

Powered by Google App Engine
This is Rietveld 408576698