src/core/SkTextBlob.cpp - Issue 1405463004: [SkTextBlob] Remove incorrect builder assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkTextBlob.cpp

Issue 1405463004: [SkTextBlob] Remove incorrect builder assert (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: win fix reloaded Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkTextBlob.cpp

diff --git a/src/core/SkTextBlob.cpp b/src/core/SkTextBlob.cpp

index 2ccf26b1c6fdd1f50009cc0f7950268f335f618d..7fd96ad8b284b1ed9625b4ab7a91dcf6e956828f 100644

--- a/src/core/SkTextBlob.cpp

+++ b/src/core/SkTextBlob.cpp

@@ -403,8 +403,6 @@ SkRect SkTextBlobBuilder::TightRunBounds(const SkTextBlob::RunRecord& run) {

}

SkASSERT((void*)glyphPosX <= SkTextBlob::RunRecord::Next(&run));

- SkASSERT(run.positioning() == SkTextBlob::kHorizontal_Positioning ||

- (void*)glyphPosY <= SkTextBlob::RunRecord::Next(&run));

return bounds.makeOffset(run.offset().x(), run.offset().y());

}

« no previous file with comments | « no previous file | tests/TextBlobTest.cpp » ('j') | no next file with comments »