Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405453003: CTZ instruction implemented as optional operator. (Closed)

Created:
5 years, 2 months ago by ahaas
Modified:
5 years, 2 months ago
Reviewers:
ahaas1, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CTZ instruction implemented as optional operator. Committed: https://crrev.com/b3334087ecb5bdab50a98b7a976c0a09dbda624a Cr-Commit-Position: refs/heads/master@{#31313}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added x64 and ia32 support. #

Patch Set 3 : Fixed a bug when bmi1=false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -3 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ahaas1
5 years, 2 months ago (2015-10-12 23:41:55 UTC) #2
titzer
Looks good other than one small detail. https://codereview.chromium.org/1405453003/diff/1/src/compiler/x64/instruction-selector-x64.cc File src/compiler/x64/instruction-selector-x64.cc (right): https://codereview.chromium.org/1405453003/diff/1/src/compiler/x64/instruction-selector-x64.cc#newcode581 src/compiler/x64/instruction-selector-x64.cc:581: void InstructionSelector::VisitWord32Ctz(Node* ...
5 years, 2 months ago (2015-10-12 23:48:48 UTC) #3
titzer
lgtm
5 years, 2 months ago (2015-10-15 16:57:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405453003/40001
5 years, 2 months ago (2015-10-15 16:57:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-15 17:01:32 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 17:01:53 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b3334087ecb5bdab50a98b7a976c0a09dbda624a
Cr-Commit-Position: refs/heads/master@{#31313}

Powered by Google App Engine
This is Rietveld 408576698