Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4772)

Unified Diff: pkg/compiler/lib/src/resolution/registry.dart

Issue 1405443004: Remove calls to registerDependency from within resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/constructors.dart ('k') | pkg/compiler/lib/src/resolution/resolution.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/registry.dart
diff --git a/pkg/compiler/lib/src/resolution/registry.dart b/pkg/compiler/lib/src/resolution/registry.dart
index b93c6e9eab7b8fa756c7b9a6c2c0a83fc6d59d7b..da2629a6b49b1a3934101464d5c0013701b443bd 100644
--- a/pkg/compiler/lib/src/resolution/registry.dart
+++ b/pkg/compiler/lib/src/resolution/registry.dart
@@ -79,15 +79,14 @@ class EagerRegistry extends Registry {
@override
void registerStaticInvocation(Element element) {
- registerDependency(element);
world.registerStaticUse(element);
}
String toString() => 'EagerRegistry for ${mapping.analyzedElement}';
}
-class _ResolutionWorldImpact implements ResolutionImpact {
- final Registry registry;
+class _ResolutionWorldImpact extends ResolutionImpact {
+ final String name;
// TODO(johnniwinther): Do we benefit from lazy initialization of the
// [Setlet]s?
Setlet<UniverseSelector> _dynamicInvocations;
@@ -108,13 +107,7 @@ class _ResolutionWorldImpact implements ResolutionImpact {
Setlet<DartType> _typeLiterals;
Setlet<String> _constSymbolNames;
- _ResolutionWorldImpact(Compiler compiler, TreeElementMapping mapping)
- : this.registry = new EagerRegistry(compiler, mapping);
-
- void registerDependency(Element element) {
- assert(element != null);
- registry.registerDependency(element);
- }
+ _ResolutionWorldImpact(this.name);
void registerDynamicGetter(UniverseSelector selector) {
assert(selector != null);
@@ -332,7 +325,7 @@ class _ResolutionWorldImpact implements ResolutionImpact {
return _features != null ? _features : const <Feature>[];
}
- String toString() => '$registry';
+ String toString() => '_ResolutionWorldImpact($name)';
}
/// [ResolutionRegistry] collects all resolution information. It stores node
@@ -347,7 +340,8 @@ class ResolutionRegistry extends Registry {
ResolutionRegistry(Compiler compiler, TreeElementMapping mapping)
: this.compiler = compiler,
this.mapping = mapping,
- this.worldImpact = new _ResolutionWorldImpact(compiler, mapping);
+ this.worldImpact = new _ResolutionWorldImpact(
+ mapping.analyzedElement.toString());
bool get isForResolution => true;
@@ -532,7 +526,7 @@ class ResolutionRegistry extends Registry {
}
void registerImplicitSuperCall(FunctionElement superConstructor) {
- registerDependency(superConstructor);
+ registerStaticUse(superConstructor);
}
// TODO(johnniwinther): Remove this.
@@ -703,8 +697,7 @@ class ResolutionRegistry extends Registry {
}
void registerStaticInvocation(Element element) {
- // TODO(johnniwinther): Increase precision of [registerStaticUse] and
- // [registerDependency].
+ // TODO(johnniwinther): Increase precision of [registerStaticUse].
if (element == null) return;
registerStaticUse(element);
}
« no previous file with comments | « pkg/compiler/lib/src/resolution/constructors.dart ('k') | pkg/compiler/lib/src/resolution/resolution.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698