Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1405443004: Remove calls to registerDependency from within resolution. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove calls to registerDependency from within resolution. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/0fb376928ecca624b65233a03ff7e1b5f2b99aa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -41 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 4 chunks +8 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 6 chunks +8 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 2 months ago (2015-10-14 07:41:25 UTC) #2
sigurdm
LGTM
5 years, 2 months ago (2015-10-14 10:40:35 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-14 13:06:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fb376928ecca624b65233a03ff7e1b5f2b99aa8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698