sdk/lib/html/html_common/conversions_dartium.dart - Issue 1405443003: Unsuppress/fix most indexeddb tests on Dartium

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/html/html_common/conversions_dartium.dart

Issue 1405443003: Unsuppress/fix most indexeddb tests on Dartium (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »

OLD	NEW
1 part of html_common;	1 part of html_common;

2	2

3 convertDartToNative_PrepareForStructuredClone(value) =>	3 convertDartToNative_PrepareForStructuredClone(value) =>

4 new _StructuredCloneDartium().convertDartToNative_PrepareForStructuredClone( value);	4 new _StructuredCloneDartium().convertDartToNative_PrepareForStructuredClone( value);

5	5

6 convertNativeToDart_AcceptStructuredClone(object, {mustCopy: false}) =>	6 convertNativeToDart_AcceptStructuredClone(object, {mustCopy: false}) =>

7 new _AcceptStructuredCloneDartium().convertNativeToDart_AcceptStructuredClon e(object, mustCopy: mustCopy);	7 new _AcceptStructuredCloneDartium().convertNativeToDart_AcceptStructuredClon e(object, mustCopy: mustCopy);

8	8

9 class _StructuredCloneDartium extends _StructuredClone {	9 class _StructuredCloneDartium extends _StructuredClone {

10 newJsMap() => new js.JsObject(js.context["Object"]);	10 newJsMap() => new js.JsObject(js.context["Object"]);

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 final _promiseConstructor = js.context['Promise'];	55 final _promiseConstructor = js.context['Promise'];

56 bool isJavaScriptPromise(value) => value is js.JsObject && value['constructor'] == _promiseConstructor;	56 bool isJavaScriptPromise(value) => value is js.JsObject && value['constructor'] == _promiseConstructor;

57	57

58 Future convertNativePromiseToDartFuture(js.JsObject promise) {	58 Future convertNativePromiseToDartFuture(js.JsObject promise) {

59 var completer = new Completer();	59 var completer = new Completer();

60 var newPromise = promise	60 var newPromise = promise

61 .callMethod("then", [(result) => completer.complete(result)])	61 .callMethod("then", [(result) => completer.complete(result)])

62 .callMethod("catch", [(result) => completer.completeError(result)]);	62 .callMethod("catch", [(result) => completer.completeError(result)]);

63 return completer.future;	63 return completer.future;

64 }	64 }

	65

	66 convertDartToNative_DateTime(DateTime date) {

	67 return new js.JsObject(js.context["Date"], [date.millisecondsSinceEpoch]);

	68 }

OLD	NEW