Issue 140543003: Tests for (pre)parse errors when "eval" and "arguments" are found in inappropriate places.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140543003: Tests for (pre)parse errors when "eval" and "arguments" are found in inappropriate places. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev, Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tests for (pre)parse errors when "eval" and "arguments" are found in inappropriate places. In addition: - Fix a bug in parser discovered by the tests (prefix and postfix confused in an error message); the preparser had it right. - Unify the parser and preparser error locations when the name of a function is "eval" or "arguments. Now both point to the name. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19050

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebased #

Patch Set 5 : comment #

Patch Set 6 : one more test (trivial change) #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -14 lines)			Patch
M	src/parser.h	View	1 2	1 chunk	+8 lines, -7 lines	0 comments	Download
M	src/parser.cc	View	1 2	7 chunks	+11 lines, -7 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 2 3 4 5	1 chunk	+142 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 10 months ago (2014-02-04 09:47:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 manually as r19050 (presubmit successful).

Expand Messages | Collapse Messages