Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h

Issue 1405413004: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarifying error messages in layout tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h
diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h b/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h
index 030586f4d409064f9104460129d823414c9ac71f..080eaed6f0020d4baac7c4620e12f9169a1eb9bb 100644
--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h
+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h
@@ -28,9 +28,16 @@
#include "modules/ModulesExport.h"
#include "modules/webaudio/AbstractAudioContext.h"
+#include "wtf/HashMap.h"
+
namespace blink {
class ExceptionState;
+class OfflineAudioDestinationHandler;
+
+// The HashMap with 'zero' key is needed because |currentSampleFrame| can be
+// zero.
+using SuspendMap = HeapHashMap<size_t, Member<ScriptPromiseResolver>, DefaultHash<size_t>::Hash, WTF::UnsignedWithZeroKeyHashTraits<size_t>>;
class MODULES_EXPORT OfflineAudioContext final : public AbstractAudioContext {
DEFINE_WRAPPERTYPEINFO();
@@ -39,16 +46,66 @@ public:
~OfflineAudioContext() override;
+ DECLARE_VIRTUAL_TRACE();
+
ScriptPromise startOfflineRendering(ScriptState*);
ScriptPromise closeContext(ScriptState*) final;
- ScriptPromise suspendContext(ScriptState*) final;
+ ScriptPromise suspendContext(ScriptState*, double) final;
ScriptPromise resumeContext(ScriptState*) final;
+ // This is to implement the pure virtual method from AbstractAudioContext.
+ // CANNOT be called from an OfflineAudioContext.
+ ScriptPromise suspendContext(ScriptState*) final;
+
bool hasRealtimeConstraint() final { return false; }
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(complete);
+
+ // Fire completion event when the rendering is suspended.
+ void fireSuspendedEvent();
+
+ // Fire completion event when the rendering is finished.
+ void fireCompletionEvent();
+
+ // This is same with the online version in AbstractAudioContext class except
+ // for returning a boolean value after checking the scheduled suspends.
+ bool handlePreOfflineRenderTasks();
+
+ void handlePostOfflineRenderTasks();
+
+ // Resolve a suspend scheduled at the specified frame. With this specified
+ // frame as a unique key, the associated promise resolver can be retrieved
+ // from the map (m_scheduledSuspends) and resolved.
+ void resolveSuspendOnMainThread(size_t);
+
private:
OfflineAudioContext(Document*, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);
+
+ // Fetch directly the destination handler.
+ OfflineAudioDestinationHandler& destinationHandler();
+
+ AudioBuffer* renderTarget() const { return m_renderTarget.get(); }
+
+ // Check if the rendering needs to be suspended.
+ bool shouldSuspend();
+
+ Member<AudioBuffer> m_renderTarget;
+
+ // This map is to store the timing of scheduled suspends (frame) and the
+ // associated promise resolver. This storage can only be modified by the
+ // main thread and accessed by the audio thread with the graph lock.
Raymond Toy 2015/10/21 18:22:45 Add comment on what the key is and the value in th
hongchan 2015/10/22 18:23:49 Done.
+ SuspendMap m_scheduledSuspends;
+
+ Member<ScriptPromiseResolver> m_completeResolver;
+
+ // This flag is necessary to indicate the rendering has actually started.
+ // Note that initial state of context is 'Suspended', which is the same
+ // state when the context is suspended.
+ bool m_isRenderingStarted;
+
+ // Total render sample length.
+ size_t m_totalRenderFrames;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698