Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

Issue 1405413004: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarifying error messages in layout tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, Google Inc. All rights reserved. 2 * Copyright (C) 2011, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y 16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y
17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N 19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N
20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #ifndef OfflineAudioDestinationNode_h 25 #ifndef OfflineAudioDestinationNode_h
26 #define OfflineAudioDestinationNode_h 26 #define OfflineAudioDestinationNode_h
27 27
28 #include "modules/webaudio/AudioBuffer.h" 28 #include "modules/webaudio/AudioBuffer.h"
29 #include "modules/webaudio/AudioDestinationNode.h" 29 #include "modules/webaudio/AudioDestinationNode.h"
30 #include "modules/webaudio/OfflineAudioContext.h"
30 #include "public/platform/WebThread.h" 31 #include "public/platform/WebThread.h"
31 #include "wtf/PassRefPtr.h" 32 #include "wtf/PassRefPtr.h"
32 #include "wtf/RefPtr.h" 33 #include "wtf/RefPtr.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 class AbstractAudioContext; 37 class AbstractAudioContext;
37 class AudioBus; 38 class AudioBus;
39 class OfflineAudioContext;
38 40
39 class OfflineAudioDestinationHandler final : public AudioDestinationHandler { 41 class OfflineAudioDestinationHandler final : public AudioDestinationHandler {
40 public: 42 public:
41 static PassRefPtr<OfflineAudioDestinationHandler> create(AudioNode&, AudioBu ffer* renderTarget); 43 static PassRefPtr<OfflineAudioDestinationHandler> create(AudioNode&, AudioBu ffer* renderTarget);
42 ~OfflineAudioDestinationHandler() override; 44 ~OfflineAudioDestinationHandler() override;
43 45
44 // AudioHandler 46 // AudioHandler
45 void dispose() override; 47 void dispose() override;
46 void initialize() override; 48 void initialize() override;
47 void uninitialize() override; 49 void uninitialize() override;
48 50
51 OfflineAudioContext* context() const final;
52
49 // AudioDestinationHandler 53 // AudioDestinationHandler
50 void startRendering() override; 54 void startRendering() override;
51 void stopRendering() override; 55 void stopRendering() override;
52 56
53 float sampleRate() const override { return m_renderTarget->sampleRate(); } 57 float sampleRate() const override { return m_renderTarget->sampleRate(); }
54 58
59 size_t renderQuantumFrames() const;
60
61 WebThread* offlineRenderThread();
62
55 private: 63 private:
56 OfflineAudioDestinationHandler(AudioNode&, AudioBuffer* renderTarget); 64 OfflineAudioDestinationHandler(AudioNode&, AudioBuffer* renderTarget);
57 void offlineRender();
58 void offlineRenderInternal();
59 65
60 // For completion callback on main thread. 66 // Set up the rendering and start. After setting the context up, it will
67 // eventually call |doOfflineRendering|.
68 void startOfflineRendering();
69
70 // Suspend the rendering loop and notify the main thread to resolve the
71 // associated promise.
72 void suspendOfflineRendering();
73
74 // Start the rendering loop.
75 void doOfflineRendering();
76
77 // Finish the rendering loop and notify the main thread to resolve the
78 // promise with the rendered buffer.
79 void finishOfflineRendering();
80
81 // Suspend/completion callbacks for the main thread.
82 void notifySuspend();
61 void notifyComplete(); 83 void notifyComplete();
62 84
85 // The offline version of render() method. virtual/override were not used
Raymond Toy 2015/10/21 18:22:46 How is virtual/override relevant? Could another c
hongchan 2015/10/22 18:23:49 I thought about overriding render() method - but I
86 // for this method to ensure the optimum performance.
87 // If the rendering needs to be suspended after checking, this stops the
88 // rendering and returns true. Otherwise, it returns false after completing
89 // the render quantum.
90 bool checkSuspendsAndRender(AudioBus* sourceBus, AudioBus* destinationBus, s ize_t numberOfFrames);
91
63 // This AudioHandler renders into this AudioBuffer. 92 // This AudioHandler renders into this AudioBuffer.
64 // This Persistent doesn't make a reference cycle including the owner 93 // This Persistent doesn't make a reference cycle including the owner
65 // OfflineAudioDestinationNode. 94 // OfflineAudioDestinationNode.
66 Persistent<AudioBuffer> m_renderTarget; 95 Persistent<AudioBuffer> m_renderTarget;
67 // Temporary AudioBus for each render quantum. 96 // Temporary AudioBus for each render quantum.
68 RefPtr<AudioBus> m_renderBus; 97 RefPtr<AudioBus> m_renderBus;
69 98
70 // Rendering thread. 99 // Rendering thread.
71 OwnPtr<WebThread> m_renderThread; 100 OwnPtr<WebThread> m_renderThread;
72 bool m_startedRendering; 101
102 // These variables are for counting the number of frames for the current
103 // progress and the remaining frames to be processed.
104 size_t m_framesProcessed;
105 size_t m_framesToProcess;
106
107 // This flag is necessary to distinguish the state of the context between
108 // 'created' and 'suspended'. If this flag is false and the current state
109 // is 'suspended', it means the context is created and have not started yet.
110 bool m_isRenderingStarted;
111
112 // This flag indicates whether the rendering should be suspended or not.
113 bool m_shouldSuspend;
73 }; 114 };
74 115
75 class OfflineAudioDestinationNode final : public AudioDestinationNode { 116 class OfflineAudioDestinationNode final : public AudioDestinationNode {
76 public: 117 public:
77 static OfflineAudioDestinationNode* create(AbstractAudioContext*, AudioBuffe r* renderTarget); 118 static OfflineAudioDestinationNode* create(AbstractAudioContext*, AudioBuffe r* renderTarget);
78 119
79 private: 120 private:
80 OfflineAudioDestinationNode(AbstractAudioContext&, AudioBuffer* renderTarget ); 121 OfflineAudioDestinationNode(AbstractAudioContext&, AudioBuffer* renderTarget );
81 }; 122 };
82 123
83 } // namespace blink 124 } // namespace blink
84 125
85 #endif // OfflineAudioDestinationNode_h 126 #endif // OfflineAudioDestinationNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698