third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt - Issue 1405413004: Implement suspend() and resume() for OfflineAudioContext

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt

Issue 1405413004: Implement suspend() and resume() for OfflineAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarifying error messages in layout tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html ('K') | « third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html ('k') | third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html » ('j') | third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Basic test for OfflineAudioContext.suspend() and OfflineAudioContext.resume().

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5

	6 PASS context.suspend() rejected correctly (with TypeError: Failed to execute 'su spend' on 'OfflineAudioContext': 1 argument required, but only 0 present.).

	7 PASS context.suspend(-1.0) rejected correctly (with InvalidStateError: negative suspend time (-1) is not allowed).

	8 PASS context.suspend(2.0) rejected correctly (with InvalidStateError: cannot sch edule a suspend at frame 88192 (2 seconds) because it is greater than or equal t o the total render duration of 44100 frames).

	9 PASS Scheduling a suspend in the past rejected correctly (with InvalidStateError : cannot schedule a suspend at frame 17536 (0.399229 seconds) because it is earl ier than the current frame of 22016 (0.499229 seconds)).

	10 PASS Scheduling a suspend in the future resolved correctly.

	11 PASS Scheduling a suspend at frame 128 was successful.

	12 PASS Scheduling another suspend at the same rendering quantum rejected correctly (with InvalidStateError: cannot schedule more than one suspend at frame 128 (0. 00435374 seconds)).

	13 PASS Scheduling a suspend at 0.5 second.

	14 PASS Resuming at 0 second (before the actual suspend happens) rejected correctly (with InvalidStateError: cannot resume a context that is running).

	15 PASS Calling resume on context without any previous suspend rejected correctly ( with InvalidStateError: cannot resume a context that has not started).
	Raymond Toy 2015/10/21 18:22:45 The description doesn't seem to match the InvalidS The description doesn't seem to match the InvalidStateError message. What is really supposed to be tested here? hongchan 2015/10/22 18:23:48 It tries to resume a context that has not started. Show quoted text On 2015/10/21 at 18:22:45, Raymond Toy wrote: > The description doesn't seem to match the InvalidStateError message. What is really supposed to be tested here? It tries to resume a context that has not started. Throwing InvalidStateError per the current spec. http://webaudio.github.io/web-audio-api/#methods-1 Raymond Toy 2015/10/22 18:41:44 The description is "resume on context without prev Show quoted text On 2015/10/22 at 18:23:48, hoch wrote: > On 2015/10/21 at 18:22:45, Raymond Toy wrote: > > The description doesn't seem to match the InvalidStateError message. What is really supposed to be tested here? > > It tries to resume a context that has not started. Throwing InvalidStateError per the current spec. > > http://webaudio.github.io/web-audio-api/#methods-1 The description is "resume on context without previous suspend". The error message is "cannot resume a context that has not been started". The context has been started, right? Perhaps the error message should include the current state. That might make it clearer why you can't resume. Basically, you can only resume if the state is "suspended", right? hongchan 2015/10/22 20:17:04 No. This is a separate test from others. It creat Show quoted text On 2015/10/22 18:41:44, Raymond Toy wrote: > On 2015/10/22 at 18:23:48, hoch wrote: > > On 2015/10/21 at 18:22:45, Raymond Toy wrote: > > > The description doesn't seem to match the InvalidStateError message. What > is really supposed to be tested here? > > > > It tries to resume a context that has not started. Throwing InvalidStateError > per the current spec. > > > > http://webaudio.github.io/web-audio-api/#methods-1 > > The description is "resume on context without previous suspend". The error > message is "cannot resume a context that has not been started". The context has > been started, right? No. This is a separate test from others. It create a new OfflineAudioContext and resume it right away. So when this check runs, the context is not started, thus the message is correct. Show quoted text > > Perhaps the error message should include the current state. That might make it > clearer why you can't resume. Basically, you can only resume if the state is > "suspended", right? Printing out the current state is not really helpful either because the context is initially 'suspended.' I am changing the description and the comment for this test task, so it makes sense. A nice catch!
	16 PASS successfullyParsed is true

	17

	18 TEST COMPLETE

	19

OLD	NEW