Implement suspend() and resume() for OfflineAudioContext

third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 149 matching lines @@
     ChannelSplitterNode* createChannelSplitter(size_t numberOfOutputs, ExceptionState&);
     ChannelMergerNode* createChannelMerger(ExceptionState&);
     ChannelMergerNode* createChannelMerger(size_t numberOfInputs, ExceptionState&);
     OscillatorNode* createOscillator(ExceptionState&);
     PeriodicWave* createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, ExceptionState&);
     PeriodicWave* createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, const Dictionary&, ExceptionState&);
 
     // Close
     virtual ScriptPromise closeContext(ScriptState*) = 0;
 
-    // Suspend/Resume
+    // Suspend for online and offline context.
     virtual ScriptPromise suspendContext(ScriptState*) = 0;
+    virtual ScriptPromise suspendContext(ScriptState*, double) = 0;
+
+    // Resume
     virtual ScriptPromise resumeContext(ScriptState*) = 0;
 
     // When a source node has started processing and needs to be protected,
     // this method tells the context to protect the node.
     //
     // The context itself keeps a reference to all source nodes.  The source
     // nodes, then reference all nodes they're connected to.  In turn, these
     // nodes reference all nodes they're connected to.  All nodes are ultimately
     // connected to the AudioDestinationNode.  When the context release a source
     // node, it will be deactivated from the rendering graph along with all
@@ skipping 38 matching lines @@
 #endif
     using AutoLocker = DeferredTaskHandler::AutoLocker;
 
     // Returns the maximum numuber of channels we can support.
     static unsigned maxNumberOfChannels() { return MaxNumberOfChannels;}
 
     // EventTarget
     const AtomicString& interfaceName() const final;
     ExecutionContext* executionContext() const final;
 
-    DEFINE_ATTRIBUTE_EVENT_LISTENER(complete);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);
 
     void startRendering();
-    void fireCompletionEvent();
     void notifyStateChange();
 
     // A context is considered closed if:
     //  - closeContext() has been called.
     //  - it has been stopped by its execution context.
     virtual bool isContextClosed() const { return m_isCleared; }
 
     // Get the security origin for this audio context.
     SecurityOrigin* securityOrigin() const;
 
 protected:
     explicit AbstractAudioContext(Document*);
     AbstractAudioContext(Document*, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate);
 
-    void setContextState(AudioContextState);
-    virtual void didClose() {}
+    void initialize();
     void uninitialize();
 
-    Member<ScriptPromiseResolver> m_offlineResolver;
+    void setContextState(AudioContextState);
+
+    virtual void didClose() {}
+
+    // Tries to handle AudioBufferSourceNodes that were started but became disconnected or was never
+    // connected. Because these never get pulled anymore, they will stay around forever. So if we
+    // can, try to stop them so they can be collected.
+    void handleStoppableSourceNodes();
+
+    Member<AudioDestinationNode> m_destinationNode;
 
     // FIXME(dominicc): Move m_resumeResolvers to AudioContext, because only
     // it creates these Promises.
     // Vector of promises created by resume(). It takes time to handle them, so we collect all of
     // the promises here until they can be resolved or rejected.
     HeapVector<Member<ScriptPromiseResolver>> m_resumeResolvers;
+
 private:
-    void initialize();

[Raymond Toy, 2015/10/16 23:32:36]

Where did initialize() go?  Is it no longer needed?

[hongchan, 2015/10/19 20:08:12]

1. initialize() has been moved to 'protected' section, since it is used when the
child object (OfflineAudioContext) finishing the constructor.
2. I believe this is okay since we already have uninitialized() method in the
protected section.

-
     bool m_isCleared;
     void clear();
 
     void throwExceptionForClosedState(ExceptionState&);
 
     // When the context goes away, there might still be some sources which
     // haven't finished playing.  Make sure to release them here.
     void releaseActiveSourceNodes();
 
-    Member<AudioDestinationNode> m_destinationNode;
     Member<AudioListener> m_listener;
 
     // Only accessed in the audio thread.
     // These raw pointers are safe because AudioSourceNodes in
     // m_activeSourceNodes own them.
     Vector<AudioHandler*> m_finishedSourceHandlers;
 
     // List of source nodes. This is either accessed when the graph lock is
     // held, or on the main thread when the audio thread has finished.
     // Oilpan: This Vector holds connection references. We must call
@@ skipping 14 matching lines @@
     // time and the audio context process loop is very fast, so we don't want to call resolve an
     // excessive number of times.
     bool m_isResolvingResumePromises;
 
     unsigned m_connectionCount;
 
     // Graph locking.
     bool m_didInitializeContextGraphMutex;
     RefPtr<DeferredTaskHandler> m_deferredTaskHandler;
 
-    Member<AudioBuffer> m_renderTarget;
-
     // The state of the AbstractAudioContext.
     AudioContextState m_contextState;
 
     AsyncAudioDecoder m_audioDecoder;
 
-    // Tries to handle AudioBufferSourceNodes that were started but became disconnected or was never
-    // connected. Because these never get pulled anymore, they will stay around forever. So if we
-    // can, try to stop them so they can be collected.
-    void handleStoppableSourceNodes();

[Raymond Toy, 2015/10/16 23:32:36]

Where is this now?

[hongchan, 2015/10/19 20:08:12]

See the protected section as well. In this patch, this method is called by
handlePreOfflineRenderTasks() which is a part of OfflineAudioContext.

-
     // This is considering 32 is large enough for multiple channels audio.
     // It is somewhat arbitrary and could be increased if necessary.
     enum { MaxNumberOfChannels = 32 };
 };
 
 } // namespace blink
 
 #endif // AbstractAudioContext_h