Add Media.AudioRendererEvents histogram to measure how often OnRenderError() is called.

media/filters/audio_renderer_impl.cc

Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index fd0a4104842ef8c97b247ad1515ad9dea0c33ae4..07b35d80bacc86b39c9635ad56c26cd98f6f16e1 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -14,6 +14,7 @@
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
+#include "base/metrics/histogram.h"
 #include "media/audio/audio_util.h"
 #include "media/base/audio_splicer.h"
 #include "media/base/bind_to_loop.h"
@@ -25,6 +26,21 @@
 
 namespace media {
 
+namespace {
+
+enum AudioRendererEvent {
+  INITIALIZED,
+  RENDER_ERROR,
+  MAX_EVENTS
+};
+
+void HistogramRendererEvent(AudioRendererEvent event) {

[DaleCurtis, 2013/04/25 17:33:06]

Unnamed namespace in media?! :)

[scherkus (not reviewing), 2013/04/25 18:28:49]

The enum declaration made me do it! (prevents possible collisions ... especially
with a value like "INITIALIZED")

+  UMA_HISTOGRAM_ENUMERATION("Media.AudioRendererEvents", event, MAX_EVENTS);
+}
+
+}  // namespace
+

[DaleCurtis, 2013/04/25 17:33:06]

extra line.

[scherkus (not reviewing), 2013/04/25 18:28:49]

Done.

+
 AudioRendererImpl::AudioRendererImpl(
     const scoped_refptr<base::MessageLoopProxy>& message_loop,
     media::AudioRendererSink* sink,
@@ -284,6 +300,8 @@ void AudioRendererImpl::OnDecoderSelected(
 
   state_ = kPaused;
 
+  HistogramRendererEvent(INITIALIZED);
+
   sink_->Initialize(audio_parameters_, weak_this_);
   sink_->Start();
 
@@ -629,6 +647,7 @@ void AudioRendererImpl::UpdateEarliestEndTime_Locked(
 }
 
 void AudioRendererImpl::OnRenderError() {
+  HistogramRendererEvent(RENDER_ERROR);
   disabled_cb_.Run();
 }