tools/metrics/histograms/histograms.xml - Issue 14054019: Add Media.AudioRendererEvents histogram to measure how often OnRenderError() is called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 14054019: Add Media.AudioRendererEvents histogram to measure how often OnRenderError() is called. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 8597b80b3a4760c23b7c79eab058eb787f16345a..6d7f9c94260a09c3709be221c94028aa74be1837 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -514,6 +514,14 @@ other types of suffix sets.

<summary>The version of glibc used. (Linux only)</summary>

</histogram>

+<histogram name="Media.AudioRendererSinkErrors">

+ <summary>

+ False is recorded whenever AudioRendererImpl successfully initializes an

jar (doing other things) 2013/04/24 21:51:07 You should add an enum to make this more readable:

scherkus (not reviewing) 2013/04/25 00:04:46 Done.

+ AudioRendererSink. True is recorded whenever a successful initialization

+ follows with the sink reporting OnRenderError().

jar (doing other things) 2013/04/24 21:51:07 nit: "follows with" --> "is followed by the"

scherkus (not reviewing) 2013/04/25 00:04:46 Reworded a bit. Mind taking another scan?

+ </summary>

+</histogram>

<summary>Audio codec used in HTML5 media.</summary>

</histogram>

« media/filters/audio_renderer_impl.cc ('K') | « media/filters/audio_renderer_impl.cc ('k') | no next file » | no next file with comments »