Crashes when percent calculation of row's height goes very high.

third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index afb1424af20b17dd535baaf7b8b72eb90a7b5c23..6bd887853b138426e7af016b2ccd36550ccca2da 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -320,7 +320,10 @@ void LayoutTableSection::distributeExtraRowSpanHeightToPercentRows(LayoutTableCe
         if (percent > 0 && extraRowSpanningHeight > 0) {
             // TODO(alancutter): Make this work correctly for calc lengths.
             if (m_grid[row].logicalHeight.hasPercent()) {
-                int toAdd = (tableHeight * m_grid[row].logicalHeight.percent() / 100) - rowsHeight[row - rowIndex];
+                float maxPercent = 100.0;

[mstensho (USE GERRIT), 2015/10/16 18:19:13]

I see no need for |maxPercent|. Just put 100.0 in the expression below.

If I were to introduce a local variable, it'd be for
m_grid[row].logicalHeight.percent(), which is used twice here.

[a.suchit2, 2015/10/19 10:01:04]

100.0 can not be used directly inside std::min because it is considered as
double and value return by m_grid[row].logicalHeight.percent() is float and
std::min gives compilation error.

[mstensho (USE GERRIT), 2015/10/19 18:17:47]

So float(100.0) should work, then.

[a.suchit2, 2015/10/20 05:15:07]

ok I will do it but I am not sure that it is acceptable or not.

+                int toAdd = (tableHeight *
+    std::min(m_grid[row].logicalHeight.percent(), maxPercent) / 100)

[mstensho (USE GERRIT), 2015/10/16 18:19:13]

Say, shouldn't you really divide by |totalPercent| and not 100 here? Especially
since we distribute the extra height over |totalPercent|%, which may be more
than 100, as far as I can tell.

[a.suchit2, 2015/10/19 10:01:04]

If we are using the |totalPercent| in place of 100 then row height is not based
on table height percent and we are consuming the whole |extraRowSpanningHeight|
height in percent cells. It means that whole |extraRowSpanningHeight| height
distributed in percent rows based on their ratio.

+    - rowsHeight[row - rowIndex];
                 // FIXME: Note that this is wrong if we have a percentage above 100% and may make us grow

[mstensho (USE GERRIT), 2015/10/16 18:19:13]

I guess this would no longer be the case, and that we'd behave correctly, even
with percent > 100?

[a.suchit2, 2015/10/19 10:01:04]

Yes, we can remove it.

                 // above the available space.