third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large.html - Issue 1405393002: Crashes when percent calculation of row's height goes very high.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large.html

Issue 1405393002: Crashes when percent calculation of row's height goes very high. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.dumpAsText();

	5 </script>

	6 <style>

	7 td { font: 20px/1 Ahem }

	8 .row-height { height : 48515% }

	9 </style>

	10 <body>

	11 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=408066">408066</a>.

	12 <br/>Page is crashing on assression when table row span cell's percent height is too large.</h3>
	mstensho (USE GERRIT) 2016/01/20 13:00:59 assertion And I think you can just remove the f assertion And I think you can just remove the first line "Test for chromium bug ...". People can use git log if they really want to know. dgrogan 2016/01/21 01:38:13 I see you're consistent with this preference :) J Show quoted text On 2016/01/20 13:00:59, mstensho wrote: > assertion > > And I think you can just remove the first line "Test for chromium bug ...". > People can use git log if they really want to know. I see you're consistent with this preference :) Just FYI, I swear Julien previously had us add these to the top of layout tests (that's why Suchit and I both did it) but I can't find those code reviews at the moment. a.suchit2 2016/01/21 07:08:40 So right now, I will leave as it is. Show quoted text On 2016/01/21 01:38:13, dgrogan wrote: > On 2016/01/20 13:00:59, mstensho wrote: > > assertion > > > > And I think you can just remove the first line "Test for chromium bug ...". > > People can use git log if they really want to know. > > I see you're consistent with this preference :) > > Just FYI, I swear Julien previously had us add these to the top of layout tests > (that's why Suchit and I both did it) but I can't find those code reviews at the > moment. So right now, I will leave as it is.
	13 <h4>For this test to PASS, it should not crash.</h4>

	14 <table>

	15 <tr class="row-height">

	16 <td height="876543210" rowspan="2">This row span cell height is too large.</td>

	17 </tr>

	18 <tr class="row-height">

	19 <td></td>

	20 </tr>

	21 </table>

	22 </body>

OLD	NEW