Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: src/typing-asm.h

Issue 1405383007: Increase strictness of asm type conversions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-cache.h ('k') | src/typing-asm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing-asm.h
diff --git a/src/typing-asm.h b/src/typing-asm.h
index a2e53636a099b777be20fdb8e02c973276e327f3..0c0758cac1a953c30b081d8ca4d61b0a3f7f289b 100644
--- a/src/typing-asm.h
+++ b/src/typing-asm.h
@@ -84,8 +84,9 @@ class AsmTyper : public AstVisitor {
void VisitWithExpectation(Expression* expr, Type* expected_type,
const char* msg);
- void VisitIntegerBinaryOperation(BinaryOperation* expr, Type* expected_type,
- Type* result_type);
+ void VisitIntegerBinaryOperation(BinaryOperation* expr, Type* left_expected,
+ Type* right_expected, Type* result_type,
+ bool conversion);
titzer 2015/11/03 18:58:49 Maybe call this bool flag bitwise and invert its s
bradn 2015/11/03 19:20:02 So these are all really bitwise (maybe I should re
Zone* zone() const { return zone_; }
« no previous file with comments | « src/type-cache.h ('k') | src/typing-asm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698