Increase strictness of asm type conversions.

Increase strictness of asm type conversions.

Only cast to integer with xor (closer to the spec which allows only ~~).
Check type matching on the bitwise operations.
Prevent mixing of types with the arthimetic operations.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/2cb3b9eaf3a6a151b7d99ffcec46313509c5249c
Cr-Commit-Position: refs/heads/master@{#31764}

[bradn, 2015-11-03 17:46:28]

Description was changed from

==========
Increase strictness on asm type conversions.

Only cast to integer with xor (closer to the spec which allows only ~~).
Check type matching on the bitwise operations.
Prevent mixing of types with the arthimetic operations.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Increase strictness of asm type conversions.

Only cast to integer with xor (closer to the spec which allows only ~~).
Check type matching on the bitwise operations.
Prevent mixing of types with the arthimetic operations.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

[bradn, 2015-11-03 17:49:05]

Patchset #2 (id:20001) has been deleted

[titzer, 2015-11-03 18:58:49]

https://codereview.chromium.org/1405383007/diff/40001/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1405383007/diff/40001/src/typing-asm.h#newcode89
src/typing-asm.h:89: bool conversion);
Maybe call this bool flag bitwise and invert its sense?

[bradn, 2015-11-03 19:20:02]

https://codereview.chromium.org/1405383007/diff/40001/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1405383007/diff/40001/src/typing-asm.h#newcode89
src/typing-asm.h:89: bool conversion);
On 2015/11/03 18:58:49, titzer wrote:
> Maybe call this bool flag bitwise and invert its sense?

So these are all really bitwise (maybe I should rename the method?)
The flag is for BIT_OR and BIT_XOR which are used in type annotations / casts so
they're more permissive.

[titzer, 2015-11-03 21:24:15]

On 2015/11/03 19:20:02, bradn wrote:
> https://codereview.chromium.org/1405383007/diff/40001/src/typing-asm.h
> File src/typing-asm.h (right):
> 
>
https://codereview.chromium.org/1405383007/diff/40001/src/typing-asm.h#newcode89
> src/typing-asm.h:89: bool conversion);
> On 2015/11/03 18:58:49, titzer wrote:
> > Maybe call this bool flag bitwise and invert its sense?
> 
> So these are all really bitwise (maybe I should rename the method?)
> The flag is for BIT_OR and BIT_XOR which are used in type annotations / casts
so
> they're more permissive.

Yeah, renaming to VisitIntegerBitwiseOperator sgtm. We use Operator (instead of
Operation) more places, and we decided to do the same in wasm.

[bradn, 2015-11-03 22:02:18]

ptal

[titzer, 2015-11-03 22:03:01]

lgtm

[bradn, 2015-11-03 22:43:47]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-11-03 22:43:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405383007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405383007/80001

[commit-bot: I haz the power, 2015-11-03 22:46:45]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-11-03 22:47:02]

Patchset 4 (id:??) landed as
https://crrev.com/2cb3b9eaf3a6a151b7d99ffcec46313509c5249c
Cr-Commit-Position: refs/heads/master@{#31764}