Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405383002: Remove check for whole image in the cache in SkGpuDevice::shouldTileImage (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove check for whole image in the cache in SkGpuDevice::shouldTileImage This was never that well justified. Committed: https://skia.googlesource.com/skia/+/1a1d0b8d07d1d1cc2e56bb4790ff62179ba0c74c

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : Remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
M src/gpu/SkGpuDevice.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 2 chunks +0 lines, -33 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
5 years, 2 months ago (2015-10-16 14:35:57 UTC) #2
robertphillips
lgtm
5 years, 2 months ago (2015-10-16 14:36:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405383002/20001
5 years, 2 months ago (2015-10-16 14:38:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/2964) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 2 months ago (2015-10-16 14:39:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405383002/40001
5 years, 2 months ago (2015-10-16 14:40:32 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 14:49:45 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1a1d0b8d07d1d1cc2e56bb4790ff62179ba0c74c

Powered by Google App Engine
This is Rietveld 408576698